On fri, 14 Sep 2012 15:54:18 +0200, David Sterba wrote:

On Thu, Sep 13, 2012 at 06:51:36PM +0800, Miao Xie wrote:

quoted

div_factor{_fine} has been implemented for two times, cleanup it.
And I move them into a independent file named math.h because they are
common math functions.

You removed the sanity checks:

-       if (factor <= 0)
-               return 0;
-       if (factor >= 100)
-               return num;

As inline functions, they should not contain complex checks, the caller should
make sure the parameters are right. I think.

in new version. And I don't think it's necessary to add an extra include
with a rather generic name and trivial code. A separate .h/.c with
non-filesystem related support code like this looks more suitable.

Do you intend to use the functions out of extent-tree.c ?

They are used in both extent-tree.c and volumes.c from the outset, but they
were implemented in these two files severally.