Re: [PATCH 03/61] ceph: Prefer IS_ERR_OR_NULL over manual NULL check
From: Viacheslav Dubeyko <hidden>
Date: 2026-03-10 18:13:45
Also in:
amd-gfx, bpf, ceph-devel, cocci, dm-devel, dri-devel, gfs2, intel-gfx, intel-wired-lan, kvm, linux-block, linux-btrfs, linux-cifs, linux-clk, linux-ext4, linux-fsdevel, linux-gpio, linux-hyperv, linux-input, linux-iommu, linux-leds, linux-media, linux-mips, linux-mm, linux-modules, linux-nfs, linux-omap, linux-phy, linux-pm, linux-rockchip, linux-s390, linux-scsi, linux-sctp, linux-security-module, linux-sh, linux-sound, linux-trace-kernel, linux-usb, linux-wireless, lkml, netdev, ntfs3, sched-ext, target-devel, v9fs
On Tue, 2026-03-10 at 12:48 +0100, Philipp Hahn wrote:
quoted hunk ↗ jump to hunk
Prefer using IS_ERR_OR_NULL() over using IS_ERR() and a manual NULL check. Change generated with coccinelle. To: Ilya Dryomov <idryomov@gmail.com> To: Alex Markuze <amarkuze@redhat.com> To: Viacheslav Dubeyko <slava@dubeyko.com> Cc: ceph-devel@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Philipp Hahn <redacted> --- fs/ceph/dir.c | 2 +- fs/ceph/snap.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)diff --git a/fs/ceph/dir.c b/fs/ceph/dir.c index 86d7aa594ea99335af3e91a95c0a418fdc1b8a8a..934250748ae4fd4c148fd27bdf91175047c2877d 100644 --- a/fs/ceph/dir.c +++ b/fs/ceph/dir.c@@ -889,7 +889,7 @@ int ceph_handle_notrace_create(struct inode *dir, struct dentry *dentry) { struct dentry *result = ceph_lookup(dir, dentry, 0); - if (result && !IS_ERR(result)) { + if (!IS_ERR_OR_NULL(result)) { /* * We created the item, then did a lookup, and found * it was already linked to another inode we alreadydiff --git a/fs/ceph/snap.c b/fs/ceph/snap.c index 52b4c2684f922bfed39550311e793bfe3622cd26..528ad581be160713f91416115659e2dc6f259576 100644 --- a/fs/ceph/snap.c +++ b/fs/ceph/snap.c@@ -902,7 +902,7 @@ int ceph_update_snap_trace(struct ceph_mds_client *mdsc, bad: err = -EIO; fail: - if (realm && !IS_ERR(realm)) + if (!IS_ERR_OR_NULL(realm)) ceph_put_snap_realm(mdsc, realm); if (first_realm) ceph_put_snap_realm(mdsc, first_realm);
Looks good. Reviewed-by: Viacheslav Dubeyko <redacted> Thanks, Slava.