Re: [PATCH] tools/sdptool: report error when local SDP server is not found
From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date: 2026-01-28 17:28:30
Hi Magdalena, On Wed, Jan 28, 2026 at 11:18 AM Magdalena Trivina Sihotang [off-list ref] wrote:
quoted hunk ↗ jump to hunk
From: Magdalena Trivina <redacted> Currently, the sdptool add, setattr and setseq commands do not report any error when the local SDP server is unavailable. Add an explicit error message so users can distinguish between successful execution and failure due to a missing local server. Signed-off-by: Magdalena Trivina Sihotang <redacted> --- tools/sdptool.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-)diff --git a/tools/sdptool.c b/tools/sdptool.c index 4e95a18d0..4f4dd41ac 100644 --- a/tools/sdptool.c +++ b/tools/sdptool.c@@ -871,8 +871,10 @@ static int cmd_setattr(int argc, char **argv) /* Do it */ sess = sdp_connect(BDADDR_ANY, BDADDR_LOCAL, 0); - if (!sess) + if (!sess) { + printf("No local SDP server!\n"); return -1; + } status = set_attrib(sess, handle, attrib, argv[2]); sdp_close(sess);@@ -1033,8 +1035,10 @@ static int cmd_setseq(int argc, char **argv) /* Do it */ sess = sdp_connect(BDADDR_ANY, BDADDR_LOCAL, 0); - if (!sess) + if (!sess) { + printf("No local SDP server!\n"); return -1; + } status = set_attribseq(sess, handle, attrib, argc, argv); sdp_close(sess);@@ -3692,8 +3696,10 @@ static int add_service(bdaddr_t *bdaddr, svc_info_t *si) return -1; sess = sdp_connect(&interface, BDADDR_LOCAL, SDP_RETRY_IF_BUSY); - if (!sess) + if (!sess) { + printf("No local SDP server!\n"); return -1; + } for (i = 0; service[i].name; i++) if (!strcasecmp(service[i].name, si->name)) { --2.34.1
Tools such as sdptool shall be considered deprecated, if you want to add records please use: https://github.com/bluez/bluez/blob/master/doc/org.bluez.ProfileManager.rst -- Luiz Augusto von Dentz