Thread (6 messages) 6 messages, 4 authors, 2026-01-20
STALE188d REVIEWED: 1 (1M)
Revisions (4)
  1. v1 [diff vs current]
  2. v2 [diff vs current]
  3. v3 [diff vs current]
  4. v3 current

[PATCH v3 1/2] Bluetooth: btnxpuart: Remove unneeded CONFIG_PM ifdef

From: Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com>
Date: 2026-01-20 06:41:20

Hi Bastien,

Thank you for the patch. I am okay with this.

Reviewed-by: Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com>

Thanks,
Neeraj
quoted hunk ↗ jump to hunk
The functions are already disabled through the use of pm_ptr() when
CONFIG_PM is disabled, and will be removed from the final linked code as
not needed.

This increases build coverage and allows to drop an #ifdef.

Signed-off-by: Bastien Nocera <hadess@hadess.net>
---
 drivers/bluetooth/btnxpuart.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/bluetooth/btnxpuart.c b/drivers/bluetooth/btnxpuart.c
index 3b1e9224e965..e7036a48ce48 100644
--- a/drivers/bluetooth/btnxpuart.c
+++ b/drivers/bluetooth/btnxpuart.c
@@ -1947,8 +1947,7 @@ static void nxp_serdev_remove(struct
serdev_device *serdev)
        hci_free_dev(hdev);
 }

-#ifdef CONFIG_PM_SLEEP
-static int nxp_serdev_suspend(struct device *dev)
+static int __maybe_unused nxp_serdev_suspend(struct device *dev)
 {
        struct btnxpuart_dev *nxpdev = dev_get_drvdata(dev);
        struct ps_data *psdata = &nxpdev->psdata; @@ -1962,7 +1961,7 @@
static int nxp_serdev_suspend(struct device *dev)
        return 0;
 }

-static int nxp_serdev_resume(struct device *dev)
+static int __maybe_unused nxp_serdev_resume(struct device *dev)
 {
        struct btnxpuart_dev *nxpdev = dev_get_drvdata(dev);
        struct ps_data *psdata = &nxpdev->psdata; @@ -1975,7 +1974,6 @@
static int nxp_serdev_resume(struct device *dev)
        ps_control(psdata->hdev, PS_STATE_AWAKE);
        return 0;
 }
-#endif

 #ifdef CONFIG_DEV_COREDUMP
 static void nxp_serdev_coredump(struct device *dev)
--
2.52.0
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help