Thread (6 messages) 6 messages, 3 authors, 2025-02-17
STALE478d

[PATCH v3 0/2] Bluetooth: btusb: Fix QCA dump packet handling and improve SKB safety

From: En-Wei Wu <hidden>
Date: 2024-12-05 07:17:42
Also in: lkml

This patch series fixes a NULL pointer dereference in the QCA firmware dump
handling and improves the safety of SKB buffer handling. The problem occurs
when processing firmware crash dumps from WCN7851/WCN6855 Bluetooth
controllers, where incorrect return value handling leads to premature SKB
freeing and subsequent NULL pointer dereference.

The series is split into two parts:
- Patch 1 fixes the NULL pointer dereference by correcting return value
  handling and splits dump packet detection into separate ACL and event
  functions
- Patch 2 improves SKB safety by using proper buffer access methods and
  adding state restoration on error paths

Changes in v3:
- Use skb_pull_data() for safe packet header access
- Split dump packet detection into separate ACL and event helpers

Changes in v2:
- Fixed typo in the title
- Re-flowed commit message line to fit 72 characters
- Added blank line before btusb_recv_acl_qca()

En-Wei Wu (2):
  Bluetooth: btusb: avoid NULL pointer dereference in skb_dequeue()
  Bluetooth: btusb: Improve SKB safety in QCA dump packet handling

 drivers/bluetooth/btusb.c | 120 +++++++++++++++++++++++---------------
 1 file changed, 74 insertions(+), 46 deletions(-)

-- 
2.43.0
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help