Re: [PATCH v4 06/14] Bluetooth: Remove unused member in struct hci_vnd_codec_v2
From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date: 2021-11-23 23:52:44
Hi Kiran, On Fri, Nov 19, 2021 at 12:16 AM Kiran K [off-list ref] wrote:
quoted hunk ↗ jump to hunk
Remove unused "u8 id" member in struct hci_vnd_codec_v2. Vendor codec is identifiable by Company Id and Vendor Id fields. Signed-off-by: Kiran K <redacted> Reviewed-by: Chethan T N <redacted> Reviewed-by: Srivatsa Ravishankar <redacted> --- include/net/bluetooth/hci.h | 1 - 1 file changed, 1 deletion(-)diff --git a/include/net/bluetooth/hci.h b/include/net/bluetooth/hci.h index e52fd2f1e046..54fae19f3758 100644 --- a/include/net/bluetooth/hci.h +++ b/include/net/bluetooth/hci.h@@ -1395,7 +1395,6 @@ struct hci_std_codecs_v2 { } __packed; struct hci_vnd_codec_v2 { - __u8 id; __le16 cid; __le16 vid; __u8 transport; --2.17.1
Not following this change, afaik LC3 for example should be id 0x06 cid/vid 0x0000 as that is not a vendor, or this is never used for codecs defined in the spec? -- Luiz Augusto von Dentz