Re: [PATCH v3 10/13] Bluetooth: Handle MSFT avdtp open event

Hi Kiran,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on bluetooth-next/master]
[also build test WARNING on v5.16-rc1 next-20211115]
[cannot apply to bluetooth/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Kiran-K/Bluetooth-Refactor-code-to-read-supported-codecs-in-getsockopt/20211115-144640
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git master
config: h8300-randconfig-s031-20211115 (attached as .config)
compiler: h8300-linux-gcc (GCC) 11.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.4-dirty
        # https://github.com/0day-ci/linux/commit/0a4eb6e6849d95c7565face4fc18ef652bacad11
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Kiran-K/Bluetooth-Refactor-code-to-read-supported-codecs-in-getsockopt/20211115-144640
        git checkout 0a4eb6e6849d95c7565face4fc18ef652bacad11
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=h8300 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <redacted>


sparse warnings: (new ones prefixed by >>)

quoted

net/bluetooth/hci_event.c:1470:38: sparse: sparse: incorrect type in argument 2 (different base types) @@     expected unsigned short [usertype] dcid @@     got restricted __le16 [usertype] dcid @@

   net/bluetooth/hci_event.c:1470:38: sparse:     expected unsigned short [usertype] dcid
   net/bluetooth/hci_event.c:1470:38: sparse:     got restricted __le16 [usertype] dcid

vim +1470 net/bluetooth/hci_event.c

  1447	
  1448	static void hci_cc_msft_avdtp_open(struct hci_dev *hdev, struct sk_buff *skb)
  1449	{
  1450		struct msft_rp_avdtp_open *rp;
  1451		struct msft_cp_avdtp_open *sent;
  1452		struct hci_conn *hconn;
  1453		struct l2cap_conn *conn;
  1454	
  1455		if (skb->len < sizeof(*rp))
  1456			return;
  1457	
  1458		rp = (void *)skb->data;
  1459	
  1460		sent = hci_sent_cmd_data(hdev, HCI_MSFT_AVDTP_CMD);
  1461	
  1462		hconn = hci_conn_hash_lookup_handle(hdev, __le16_to_cpu(sent->handle));
  1463	
  1464		if (!hconn)
  1465			return;
  1466	
  1467		conn = hconn->l2cap_data;
  1468	
  1469		/* wake up the task waiting on avdtp handle */

1470		l2cap_avdtp_wakeup(conn, sent->dcid, rp->status,

  1471				   rp->status ? 0 : __le16_to_cpu(rp->avdtp_handle));
  1472	}
  1473	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org