Thread (11 messages) flat view 11 messages, 2 authors, 2021-10-18
STALE1801d

[BlueZ PATCH 6/9] profiles/input: Fix unchecked return value

From: Tedd Ho-Jeong An <hidden>
Date: 2021-10-18 17:28:47
Subsystem: the rest · Maintainer: Linus Torvalds

From: Tedd Ho-Jeong An <redacted>

This patch fixes the unchecked return value(CWE-252) issues reported by
the Coverity.
---
 profiles/input/device.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/profiles/input/device.c b/profiles/input/device.c
index 50ae51855..013899211 100644
--- a/profiles/input/device.c
+++ b/profiles/input/device.c
@@ -1050,7 +1050,11 @@ static int hidp_add_connection(struct input_device *idev)
 	sprintf(handle, "0x%8.8X", idev->handle);
 
 	key_file = g_key_file_new();
-	g_key_file_load_from_file(key_file, filename, 0, NULL);
+	if (!g_key_file_load_from_file(key_file, filename, 0, &gerr)) {
+		error("Unable to load key file from %s: (%s)", filename,
+								gerr->message);
+		g_error_free(gerr);
+	}
 	str = g_key_file_get_string(key_file, "ServiceRecords", handle, NULL);
 	g_key_file_free(key_file);
 
-- 
2.25.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help