Thread (7 messages) flat view 7 messages, 5 authors, 2021-09-26

Re: [PATCH v3 1/3] Bluetooth: btandroid: Support Android Bluetooth Quality Report

From: Marcel Holtmann <marcel@holtmann.org>
Date: 2021-09-13 14:37:24
Also in: lkml

Hi Joseph,
Add the btandroid.c file to support Android BQR commands.

This module may be referenced by btusb, btrtl, and hci_qca when a
Bluetooth controller supports the Android Bluetooth Quality Report.

Reported-by: kernel test robot <redacted>

Reviewed-by: Miao-chen Chou <redacted>
Signed-off-by: Joseph Hwang <redacted>
---

Changes in v3:
- Fix the auto build test ERROR
 "undefined symbol: btandroid_set_quality_report" that occurred
 with some kernel configs.
- Note that the mgmt-tester "Read Exp Feature - Success" failed.
 But on my test device, the same test passed. Please kindly let me
 know what may be going wrong. These patches do not actually
 modify read/set experimental features.
- As to CheckPatch failed. No need to modify the MAINTAINERS file.
 Thanks.

Changes in v2:
- Fix the titles of patches 2/3 and 3/3 and reduce their lengths.

drivers/bluetooth/Kconfig     |   5 ++
drivers/bluetooth/Makefile    |   1 +
drivers/bluetooth/btandroid.c | 106 ++++++++++++++++++++++++++++++++++
drivers/bluetooth/btandroid.h |  10 ++++
4 files changed, 122 insertions(+)
create mode 100644 drivers/bluetooth/btandroid.c
create mode 100644 drivers/bluetooth/btandroid.h
I am confused now. Did you read my review comments? I do _not_ want it this way; so please read my previous response and don’t send the exact same patch again.

Regards

Marcel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help