Thread (3 messages) flat view 3 messages, 3 authors, 2021-09-10

Re: [PATCH -next] Bluetooth: btusb: Fix the application of sizeof to pointer

From: Marcel Holtmann <marcel@holtmann.org>
Date: 2021-09-10 07:33:52
Also in: lkml

Hi Yang,
quoted hunk ↗ jump to hunk
sizeof() when applied to a pointer typed expression gives the size of
the pointer.

Clean up coccicheck warning:
./drivers/bluetooth/btusb.c:2210:36-42: ERROR: application of sizeof to
pointer

Reported-by: Abaci Robot <redacted>
Signed-off-by: Yang Li <redacted>
---
drivers/bluetooth/btusb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index 928cbfa..5bf479e 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -2207,7 +2207,7 @@ static int btusb_set_bdaddr_mtk(struct hci_dev *hdev, const bdaddr_t *bdaddr)
	struct sk_buff *skb;
	long ret;

-	skb = __hci_cmd_sync(hdev, 0xfc1a, sizeof(bdaddr), bdaddr, HCI_INIT_TIMEOUT);
+	skb = __hci_cmd_sync(hdev, 0xfc1a, sizeof(*bdaddr), bdaddr, HCI_INIT_TIMEOUT);
lets just do 0xfc1a, 6, bdaddr like the other functions do as well.

Regards

Marcel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help