Thread (5 messages) read the whole thread 5 messages, 3 authors, 2021-08-03

Re: [RESEND 2/2] Bluetooth: Fix not generating RPA when required

From: Marcel Holtmann <marcel@holtmann.org>
Date: 2021-08-03 21:32:13

Hi Luiz,
Code was checking if random_addr and hdev->rpa match without first
checking if the RPA has not been set (BDADDR_ANY), furthermore it was
clearing HCI_RPA_EXPIRED before the command completes and the RPA is
actually programmed which in case of failure would leave the expired
RPA still set.

Since advertising instance have a similar problem the clearing of
HCI_RPA_EXPIRED has been moved to hci_event.c after checking the random
address is in fact the hdev->rap and then proceed to set the expire
timeout.

Signed-off-by: Luiz Augusto von Dentz <redacted>
---
include/net/bluetooth/hci_core.h |  4 ++
net/bluetooth/hci_event.c        | 32 +++++++++----
net/bluetooth/hci_request.c      | 81 ++++++++++++++------------------
3 files changed, 61 insertions(+), 56 deletions(-)
patch has been applied to bluetooth-next tree.

Regards

Marcel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help