Re: [PATCH v3] Bluetooth: btusb: Add support different nvm to distinguish different factory for WCN6855 controller

Hi Zijun,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on bluetooth-next/master]
[also build test ERROR on linus/master v5.14-rc5 next-20210812]
[cannot apply to bluetooth/master linux/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Zijun-Hu/Bluetooth-btusb-Add-support-different-nvm-to-distinguish-different-factory-for-WCN6855-controller/20210812-165229
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git master
config: alpha-randconfig-s032-20210811 (attached as .config)
compiler: alpha-linux-gcc (GCC) 10.3.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.3-348-gf0e6938b-dirty
        # https://github.com/0day-ci/linux/commit/c9758b351006b29772f27d1e5e7fe904270f1356
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Zijun-Hu/Bluetooth-btusb-Add-support-different-nvm-to-distinguish-different-factory-for-WCN6855-controller/20210812-165229
        git checkout c9758b351006b29772f27d1e5e7fe904270f1356
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=alpha 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <redacted>

All errors (new ones prefixed by >>):

   drivers/bluetooth/btusb.c: In function 'btusb_setup_qca_form_nvm_name':
   drivers/bluetooth/btusb.c:3371:1: error: no return statement in function returning non-void [-Werror=return-type]
    3371 | }
         | ^
   drivers/bluetooth/btusb.c: In function 'btusb_setup_qca_load_nvm':

quoted

drivers/bluetooth/btusb.c:3385:34: error: passing argument 1 of 'btusb_setup_qca_form_nvm_name' from incompatible pointer type [-Werror=incompatible-pointer-types]

    3385 |    btusb_setup_qca_form_nvm_name(&fwname, sizeof(fwname), ver, "gf");
         |                                  ^~~~~~~
         |                                  |
         |                                  char (*)[64]
   drivers/bluetooth/btusb.c:3340:49: note: expected 'char **' but argument is of type 'char (*)[64]'
    3340 | static int btusb_setup_qca_form_nvm_name(char **fwname,
         |                                          ~~~~~~~^~~~~~
   drivers/bluetooth/btusb.c:3393:34: error: passing argument 1 of 'btusb_setup_qca_form_nvm_name' from incompatible pointer type [-Werror=incompatible-pointer-types]
    3393 |    btusb_setup_qca_form_nvm_name(&fwname, sizeof(fwname), ver, NULL);
         |                                  ^~~~~~~
         |                                  |
         |                                  char (*)[64]
   drivers/bluetooth/btusb.c:3340:49: note: expected 'char **' but argument is of type 'char (*)[64]'
    3340 | static int btusb_setup_qca_form_nvm_name(char **fwname,
         |                                          ~~~~~~~^~~~~~
   cc1: some warnings being treated as errors


vim +/btusb_setup_qca_form_nvm_name +3385 drivers/bluetooth/btusb.c

  3372	
  3373	static int btusb_setup_qca_load_nvm(struct hci_dev *hdev,
  3374					    struct qca_version *ver,
  3375					    const struct qca_device_info *info)
  3376	{
  3377		const struct firmware *fw;
  3378		char fwname[64];
  3379		int err;
  3380	
  3381		switch (ver->ram_version) {
  3382		case WCN6855_2_0_RAM_VERSION_GF:
  3383		case WCN6855_2_1_RAM_VERSION_GF:
  3384			if (((ver->flag >> 8) & 0xff) == QCA_FLAG_MULTI_NVM) {

3385				btusb_setup_qca_form_nvm_name(&fwname, sizeof(fwname), ver, "gf");

  3386			} else {
  3387				snprintf(fwname, sizeof(fwname), "qca/nvm_usb_%08x.bin",
  3388					 le32_to_cpu(ver->rom_version));
  3389			}
  3390			break;
  3391		default:
  3392			if (((ver->flag >> 8) & 0xff) == QCA_FLAG_MULTI_NVM) {
  3393				btusb_setup_qca_form_nvm_name(&fwname, sizeof(fwname), ver, NULL);
  3394			} else {
  3395				snprintf(fwname, sizeof(fwname), "qca/nvm_usb_%08x.bin",
  3396					 le32_to_cpu(ver->rom_version));
  3397			}
  3398			break;
  3399		}
  3400	
  3401		err = request_firmware(&fw, fwname, &hdev->dev);
  3402		if (err) {
  3403			bt_dev_err(hdev, "failed to request NVM file: %s (%d)",
  3404				   fwname, err);
  3405			return err;
  3406		}
  3407	
  3408		bt_dev_info(hdev, "using NVM file: %s", fwname);
  3409	
  3410		err = btusb_setup_qca_download_fw(hdev, fw, info->nvm_hdr);
  3411	
  3412		release_firmware(fw);
  3413	
  3414		return err;
  3415	}
  3416	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org