Thread (1 message) 1 message, 1 author, 2021-08-05

Re: [PATCH 1/1] Bluetooth: btusb: Fix fall-through warnings

From: Marcel Holtmann <marcel@holtmann.org>
Date: 2021-08-05 13:18:28
Also in: linux-mediatek, lkml

Hi Mark,
quoted hunk
Fix fall-through warnings:
drivers/bluetooth/btusb.c: In function ‘btusb_recv_acl_mtk’:
drivers/bluetooth/btusb.c:4033:3: warning:
this statement may fall through [-Wimplicit-fallthrough=]
4033 |   usb_disable_autosuspend(data->udev);
     |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/bluetooth/btusb.c:4034:2: note: here
4034 |  case 0x05ff:  /* Firmware debug logging 1 */
     |  ^~~~

Signed-off-by: mark-yw.chen <redacted>
---
drivers/bluetooth/btusb.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index a4cee8327295..89ff9182b7e2 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -4027,7 +4027,9 @@ static int btusb_recv_acl_mtk(struct hci_dev *hdev, struct sk_buff *skb)
		 * suspend and thus disable auto-suspend.
		 */
		usb_disable_autosuspend(data->udev);
+		fallthrough;
	case 0x05ff:		/* Firmware debug logging 1 */
+		fallthrough;
this one is not needed.

	case 0x05fe:		/* Firmware debug logging 2 */
		return hci_recv_diag(hdev, skb);
	}
Regards

Marcel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help