Re: [PATCH] Bluetooth: sco: prevent information leak in sco_conn_defer_accept()
From: Marcel Holtmann <marcel@holtmann.org>
Date: 2021-07-22 14:14:36
Also in:
kernel-janitors
From: Marcel Holtmann <marcel@holtmann.org>
Date: 2021-07-22 14:14:36
Also in:
kernel-janitors
Hi Dan,
Smatch complains that some of these struct members are not initialized
leading to a stack information disclosure:
net/bluetooth/sco.c:778 sco_conn_defer_accept() warn:
check that 'cp.retrans_effort' doesn't leak information
This seems like a valid warning. I've added a default case to fix
this issue. It's sort of unusual to have case SCO_AIRMODE_CVSD,
followed by a default case but I think it's nicely readable. :)
Fixes: 2f69a82acf6f ("Bluetooth: Use voice setting in deferred SCO connection request")
Signed-off-by: Dan Carpenter <redacted>
---
net/bluetooth/sco.c | 1 +
1 file changed, 1 insertion(+)I actually prefer a separate default statement since otherwise I get confused. Your patch with that minor change has been applied to bluetooth-next tree. Regards Marcel