Thread (2 messages) 2 messages, 1 author, 2021-06-24

Re: [PATCH BlueZ] media: Fix UnregisterApplication

From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date: 2021-06-24 20:13:24

Hi,

On Wed, Jun 23, 2021 at 3:45 PM Luiz Augusto von Dentz
[off-list ref] wrote:
quoted hunk ↗ jump to hunk
From: Luiz Augusto von Dentz <redacted>

UnregisterApplication is not doing anything since the apps queue is
never initialized which results in not finding any application when
unregistering.

Fixes: https://github.com/bluez/bluez/issues/126
---
 profiles/audio/media.c | 3 +++
 1 file changed, 3 insertions(+)
diff --git a/profiles/audio/media.c b/profiles/audio/media.c
index c84bbe22d..267722542 100644
--- a/profiles/audio/media.c
+++ b/profiles/audio/media.c
@@ -2384,6 +2384,8 @@ static void path_free(void *data)
 {
        struct media_adapter *adapter = data;

+       queue_destroy(adapter->apps, app_free);
+
        while (adapter->endpoints)
                release_endpoint(adapter->endpoints->data);
@@ -2402,6 +2404,7 @@ int media_register(struct btd_adapter *btd_adapter)

        adapter = g_new0(struct media_adapter, 1);
        adapter->btd_adapter = btd_adapter_ref(btd_adapter);
+       adapter->apps = queue_new();

        if (!g_dbus_register_interface(btd_get_dbus_connection(),
                                        adapter_get_path(btd_adapter),
--
2.31.1
Pushed.

-- 
Luiz Augusto von Dentz
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help