Re: [PATCH v1] Bluetooth: btintel: Support Digital(N) + RF(N-1) combination

Hi Kiran,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on bluetooth-next/master]
[also build test WARNING on bluetooth/master v5.13-rc6 next-20210616]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Kiran-K/Bluetooth-btintel-Support-Digital-N-RF-N-1-combination/20210616-183512
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth-next.git master
config: x86_64-randconfig-a015-20210615 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 64720f57bea6a6bf033feef4a5751ab9c0c3b401)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # https://github.com/0day-ci/linux/commit/6e8c708932770f46284508ca6f027fa39393389e
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Kiran-K/Bluetooth-btintel-Support-Digital-N-RF-N-1-combination/20210616-183512
        git checkout 6e8c708932770f46284508ca6f027fa39393389e
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <redacted>

All warnings (new ones prefixed by >>):

quoted

drivers/bluetooth/btintel.c:486:6: warning: no previous prototype for function 'btintel_parse_version_tlv' [-Wmissing-prototypes]

   void btintel_parse_version_tlv(struct hci_dev *hdev, struct sk_buff *skb,
        ^
   drivers/bluetooth/btintel.c:486:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   void btintel_parse_version_tlv(struct hci_dev *hdev, struct sk_buff *skb,
   ^
   static 
   1 warning generated.


vim +/btintel_parse_version_tlv +486 drivers/bluetooth/btintel.c

   485	
 > 486	void btintel_parse_version_tlv(struct hci_dev *hdev, struct sk_buff *skb,
   487				       struct intel_version_tlv *version)
   488	{
   489		/* Consume Command Complete Status field */
   490		skb_pull(skb, sizeof(__u8));
   491	
   492		/* Event parameters contatin multiple TLVs. Read each of them
   493		 * and only keep the required data. Also, it use existing legacy
   494		 * version field like hw_platform, hw_variant, and fw_variant
   495		 * to keep the existing setup flow
   496		 */
   497		while (skb->len) {
   498			struct intel_tlv *tlv;
   499	
   500			tlv = (struct intel_tlv *)skb->data;
   501			switch (tlv->type) {
   502			case INTEL_TLV_CNVI_TOP:
   503				version->cnvi_top = get_unaligned_le32(tlv->val);
   504				break;
   505			case INTEL_TLV_CNVR_TOP:
   506				version->cnvr_top = get_unaligned_le32(tlv->val);
   507				break;
   508			case INTEL_TLV_CNVI_BT:
   509				version->cnvi_bt = get_unaligned_le32(tlv->val);
   510				break;
   511			case INTEL_TLV_CNVR_BT:
   512				version->cnvr_bt = get_unaligned_le32(tlv->val);
   513				break;
   514			case INTEL_TLV_DEV_REV_ID:
   515				version->dev_rev_id = get_unaligned_le16(tlv->val);
   516				break;
   517			case INTEL_TLV_IMAGE_TYPE:
   518				version->img_type = tlv->val[0];
   519				break;
   520			case INTEL_TLV_TIME_STAMP:
   521				version->timestamp = get_unaligned_le16(tlv->val);
   522				break;
   523			case INTEL_TLV_BUILD_TYPE:
   524				version->build_type = tlv->val[0];
   525				break;
   526			case INTEL_TLV_BUILD_NUM:
   527				version->build_num = get_unaligned_le32(tlv->val);
   528				break;
   529			case INTEL_TLV_SECURE_BOOT:
   530				version->secure_boot = tlv->val[0];
   531				break;
   532			case INTEL_TLV_OTP_LOCK:
   533				version->otp_lock = tlv->val[0];
   534				break;
   535			case INTEL_TLV_API_LOCK:
   536				version->api_lock = tlv->val[0];
   537				break;
   538			case INTEL_TLV_DEBUG_LOCK:
   539				version->debug_lock = tlv->val[0];
   540				break;
   541			case INTEL_TLV_MIN_FW:
   542				version->min_fw_build_nn = tlv->val[0];
   543				version->min_fw_build_cw = tlv->val[1];
   544				version->min_fw_build_yy = tlv->val[2];
   545				break;
   546			case INTEL_TLV_LIMITED_CCE:
   547				version->limited_cce = tlv->val[0];
   548				break;
   549			case INTEL_TLV_SBE_TYPE:
   550				version->sbe_type = tlv->val[0];
   551				break;
   552			case INTEL_TLV_OTP_BDADDR:
   553				memcpy(&version->otp_bd_addr, tlv->val, tlv->len);
   554				break;
   555			default:
   556				/* Ignore rest of information */
   557				break;
   558			}
   559			/* consume the current tlv and move to next*/
   560			skb_pull(skb, tlv->len + sizeof(*tlv));
   561		}
   562	}
   563	EXPORT_SYMBOL_GPL(btintel_parse_version_tlv);
   564	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org