Thread (5 messages) 5 messages, 3 authors, 2021-02-26

Re: [PATCH v4] Bluetooth: Keep MSFT ext info throughout a hci_dev's life cycle

From: Marcel Holtmann <marcel@holtmann.org>
Date: 2021-02-26 20:32:03
Also in: lkml, netdev

Hi Miao-chen,
This moves msft_do_close() from hci_dev_do_close() to
hci_unregister_dev() to avoid clearing MSFT extension info. This also
re-reads MSFT info upon every msft_do_open() even if MSFT extension has
been initialized.

The following test steps were performed.
(1) boot the test device and verify the MSFT support debug log in syslog
(2) restart bluetoothd and verify msft_do_close() doesn't get invoked
   and msft_do_open re-reads the MSFT support.

Signed-off-by: Miao-chen Chou <redacted>
Reviewed-by: Abhishek Pandit-Subedi <abhishekpandit@chromium.org>
Reviewed-by: Archie Pusaka <redacted>
Reviewed-by: Alain Michaud <redacted>
---

Changes in v4:
- Re-read the MSFT data instead of skipping if it's initiated already

Changes in v3:
- Remove the accepted commits from the series

net/bluetooth/hci_core.c |  4 ++--
net/bluetooth/msft.c     | 21 ++++++++++++++++++---
2 files changed, 20 insertions(+), 5 deletions(-)
can you please re-base this against bluetooth-next tree since it no longer applies cleanly. Thanks.

Regards

Marcel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help