Thread (4 messages) flat view 4 messages, 2 authors, 2021-01-06

Re: [Bluez PATCH v3 2/2] lib/mgmt: Adding Add Adv Patterns Monitor RSSI opcode

From: Archie Pusaka <hidden>
Date: 2021-01-06 10:44:21

Hi Bluez maintainers,

I just noticed that only patch 1/2 of the series is applied, and this
one has not.
Could you re-check this one please?
Or is it expected that I also submit the code which uses this API in
the same patch series?

Thanks,
Archie

On Wed, 16 Dec 2020 at 11:43, Archie Pusaka [off-list ref] wrote:
quoted hunk ↗ jump to hunk
From: Archie Pusaka <redacted>

The new op is to utilize RSSI in advertisement monitor

Reviewed-by: Manish Mandlik <redacted>
Reviewed-by: Miao-chen Chou <redacted>
Reviewed-by: Yun-Hao Chung <redacted>
---

Changes in v3:
* Flip the order of rssi data and pattern count

Changes in v2:
* Remove the trailing period on the commit title

 lib/mgmt.h | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
diff --git a/lib/mgmt.h b/lib/mgmt.h
index f37f7e6540..76a03c9c24 100644
--- a/lib/mgmt.h
+++ b/lib/mgmt.h
@@ -738,6 +738,21 @@ struct mgmt_rp_add_ext_adv_data {
        uint8_t instance;
 } __packed;

+struct mgmt_adv_rssi_thresholds {
+       int8_t   high_threshold;
+       uint16_t high_threshold_timeout;
+       int8_t   low_threshold;
+       uint16_t low_threshold_timeout;
+       uint8_t  sampling_period;
+} __packed;
+
+#define MGMT_OP_ADD_ADV_PATTERNS_MONITOR_RSSI  0x0056
+struct mgmt_cp_add_adv_patterns_monitor_rssi {
+       struct mgmt_adv_rssi_thresholds rssi;
+       uint8_t pattern_count;
+       struct mgmt_adv_pattern patterns[0];
+} __packed;
+
 #define MGMT_EV_CMD_COMPLETE           0x0001
 struct mgmt_ev_cmd_complete {
        uint16_t opcode;
--
2.29.2.684.gfbc64c5ab5-goog
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help