Bluetooth: btusb: fix memory leak on suspend and resume

Started by Vamshi K Sthambamkadi on Jan 14, 2021 · 3 messages from 3 authors · Last reply Jan 25, 2021

Subsystems (2)

Maintainers (3)

STALE2119d

Vamshi K Sthambamkadi Jan 14, 11:22 #

Message details and related content

Open message details and related content

kmemleak report:
unreferenced object 0xffff9b1127f00500 (size 208):
  comm "kworker/u17:2", pid 500, jiffies 4294937470 (age 580.136s)
  hex dump (first 32 bytes):
    00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
    00 60 ed 05 11 9b ff ff 00 00 00 00 00 00 00 00  .`..............
  backtrace:
    [<000000006ab3fd59>] kmem_cache_alloc_node+0x17a/0x480
    [<0000000051a5f6f9>] __alloc_skb+0x5b/0x1d0
    [<0000000037e2d252>] hci_prepare_cmd+0x32/0xc0 [bluetooth]
    [<0000000010b586d5>] hci_req_add_ev+0x84/0xe0 [bluetooth]
    [<00000000d2deb520>] hci_req_clear_event_filter+0x42/0x70 [bluetooth]
    [<00000000f864bd8c>] hci_req_prepare_suspend+0x84/0x470 [bluetooth]
    [<000000001deb2cc4>] hci_prepare_suspend+0x31/0x40 [bluetooth]
    [<000000002677dd79>] process_one_work+0x209/0x3b0
    [<00000000aaa62b07>] worker_thread+0x34/0x400
    [<00000000826d176c>] kthread+0x126/0x140
    [<000000002305e558>] ret_from_fork+0x22/0x30
unreferenced object 0xffff9b1125c6ee00 (size 512):
  comm "kworker/u17:2", pid 500, jiffies 4294937470 (age 580.136s)
  hex dump (first 32 bytes):
    04 00 00 00 0d 00 00 00 05 0c 01 00 11 9b ff ff  ................
    00 00 00 00 00 00 00 00 01 00 00 00 00 00 00 00  ................
  backtrace:
    [<000000009f07c0cc>] slab_post_alloc_hook+0x59/0x270
    [<0000000049431dc2>] __kmalloc_node_track_caller+0x15f/0x330
    [<00000000027a42f6>] __kmalloc_reserve.isra.70+0x31/0x90
    [<00000000e8e3e76a>] __alloc_skb+0x87/0x1d0
    [<0000000037e2d252>] hci_prepare_cmd+0x32/0xc0 [bluetooth]
    [<0000000010b586d5>] hci_req_add_ev+0x84/0xe0 [bluetooth]
    [<00000000d2deb520>] hci_req_clear_event_filter+0x42/0x70 [bluetooth]
    [<00000000f864bd8c>] hci_req_prepare_suspend+0x84/0x470 [bluetooth]
    [<000000001deb2cc4>] hci_prepare_suspend+0x31/0x40 [bluetooth]
    [<000000002677dd79>] process_one_work+0x209/0x3b0
    [<00000000aaa62b07>] worker_thread+0x34/0x400
    [<00000000826d176c>] kthread+0x126/0x140
    [<000000002305e558>] ret_from_fork+0x22/0x30
unreferenced object 0xffff9b112b395788 (size 8):
  comm "kworker/u17:2", pid 500, jiffies 4294937470 (age 580.136s)
  hex dump (first 8 bytes):

71 more lines

diff --git a/net/bluetooth/hci_core.c b/net/bluetooth/hci_core.c
index 9d2c9a1c552f..1c793e6eb92a 100644
--- a/net/bluetooth/hci_core.c
+++ b/net/bluetooth/hci_core.c

@@ -3566,7 +3566,8 @@ static int hci_suspend_notifier(struct notifier_block *nb, unsigned long action,
 	}
 
 	/* Suspend notifier should only act on events when powered. */
-	if (!hdev_is_powered(hdev))
+	if (!hdev_is_powered(hdev) ||
+	    hci_dev_test_flag(hdev, HCI_UNREGISTER))
 		goto done;
 
 	if (action == PM_SUSPEND_PREPARE) {

-- 
2.17.1

RE: [v2] Bluetooth: btusb: fix memory leak on suspend and resume

unknown sender replied to Vamshi K Sthambamkadi Jan 14, 12:40 #

Message details and related content

Open message details and related content

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=414539

---Test result---

##############################
    Test: CheckPatch - PASS
    

    ##############################
    Test: CheckGitLint - FAIL
    workflow: Add workflow files for ci
1: T1 Title exceeds max length (92>72): "Merge 5967244da8730e087621d479bde1e2e7c9f0bc30 into 54ab037edd8cd4936ce07cb8298e71f9bafee58d"
3: B6 Body message is missing

Bluetooth: btusb: fix memory leak on suspend and resume
1: T1 Title exceeds max length (92>72): "Merge 5967244da8730e087621d479bde1e2e7c9f0bc30 into 54ab037edd8cd4936ce07cb8298e71f9bafee58d"
3: B6 Body message is missing


    ##############################
    Test: CheckBuildK - PASS
    

    ##############################
    Test: CheckTestRunner: Setup - PASS
    

    ##############################
    Test: CheckTestRunner: l2cap-tester - PASS
    Total: 40, Passed: 34 (85.0%), Failed: 0, Not Run: 6

    ##############################
    Test: CheckTestRunner: bnep-tester - PASS
    Total: 1, Passed: 1 (100.0%), Failed: 0, Not Run: 0

27 more lines

Marcel Holtmann replied to Vamshi K Sthambamkadi Jan 25, 18:27 #

Message details and related content

Open message details and related content

Hi Vamshi,

kmemleak report:
unreferenced object 0xffff9b1127f00500 (size 208):
 comm "kworker/u17:2", pid 500, jiffies 4294937470 (age 580.136s)
 hex dump (first 32 bytes):
   00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
   00 60 ed 05 11 9b ff ff 00 00 00 00 00 00 00 00  .`..............
 backtrace:
   [<000000006ab3fd59>] kmem_cache_alloc_node+0x17a/0x480
   [<0000000051a5f6f9>] __alloc_skb+0x5b/0x1d0
   [<0000000037e2d252>] hci_prepare_cmd+0x32/0xc0 [bluetooth]
   [<0000000010b586d5>] hci_req_add_ev+0x84/0xe0 [bluetooth]
   [<00000000d2deb520>] hci_req_clear_event_filter+0x42/0x70 [bluetooth]
   [<00000000f864bd8c>] hci_req_prepare_suspend+0x84/0x470 [bluetooth]
   [<000000001deb2cc4>] hci_prepare_suspend+0x31/0x40 [bluetooth]
   [<000000002677dd79>] process_one_work+0x209/0x3b0
   [<00000000aaa62b07>] worker_thread+0x34/0x400
   [<00000000826d176c>] kthread+0x126/0x140
   [<000000002305e558>] ret_from_fork+0x22/0x30
unreferenced object 0xffff9b1125c6ee00 (size 512):
 comm "kworker/u17:2", pid 500, jiffies 4294937470 (age 580.136s)
 hex dump (first 32 bytes):
   04 00 00 00 0d 00 00 00 05 0c 01 00 11 9b ff ff  ................
   00 00 00 00 00 00 00 00 01 00 00 00 00 00 00 00  ................
 backtrace:
   [<000000009f07c0cc>] slab_post_alloc_hook+0x59/0x270
   [<0000000049431dc2>] __kmalloc_node_track_caller+0x15f/0x330
   [<00000000027a42f6>] __kmalloc_reserve.isra.70+0x31/0x90
   [<00000000e8e3e76a>] __alloc_skb+0x87/0x1d0
   [<0000000037e2d252>] hci_prepare_cmd+0x32/0xc0 [bluetooth]
   [<0000000010b586d5>] hci_req_add_ev+0x84/0xe0 [bluetooth]
   [<00000000d2deb520>] hci_req_clear_event_filter+0x42/0x70 [bluetooth]
   [<00000000f864bd8c>] hci_req_prepare_suspend+0x84/0x470 [bluetooth]
   [<000000001deb2cc4>] hci_prepare_suspend+0x31/0x40 [bluetooth]
   [<000000002677dd79>] process_one_work+0x209/0x3b0
   [<00000000aaa62b07>] worker_thread+0x34/0x400
   [<00000000826d176c>] kthread+0x126/0x140
   [<000000002305e558>] ret_from_fork+0x22/0x30
unreferenced object 0xffff9b112b395788 (size 8):
 comm "kworker/u17:2", pid 500, jiffies 4294937470 (age 580.136s)
 hex dump (first 8 bytes):

70 more quoted lines

patch has been applied to bluetooth-next tree.

Regards

Marcel

`h`	back out one level
`j`	next message in thread / next series-diff position
`k`	previous message in thread / previous series-diff position
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help