Re: [PATCH 00/20] crypto: introduce crypto_shash_tfm_digest()

From
Herbert Xu <herbert@gondor.apana.org.au>
Date
2020-05-08 06:07:33
Also in
keyrings, linux-crypto, linux-nfs, linux-sctp
Reply to
Eric Biggers, 2020-05-02
Eric Biggers [off-list ref] wrote:
This series introduces a helper function crypto_shash_tfm_digest() which
replaces the following common pattern:

       {
               SHASH_DESC_ON_STACK(desc, tfm);
               int err;

               desc->tfm = tfm;

               err = crypto_shash_digest(desc, data, len, out);

               shash_desc_zero(desc);
       }

with:

       err = crypto_shash_tfm_digest(tfm, data, len, out);

Patch 1 introduces this helper function, and patches 2-20 convert all
relevant users to use it.

IMO, it would be easiest to take all these patches through the crypto
tree.  But taking just the "crypto:" ones and then me trying to get the
rest merged later via subsystem trees is also an option.

Eric Biggers (20):
 crypto: hash - introduce crypto_shash_tfm_digest()
 crypto: arm64/aes-glue - use crypto_shash_tfm_digest()
 crypto: essiv - use crypto_shash_tfm_digest()
 crypto: artpec6 - use crypto_shash_tfm_digest()
 crypto: ccp - use crypto_shash_tfm_digest()
 crypto: ccree - use crypto_shash_tfm_digest()
 crypto: hisilicon/sec2 - use crypto_shash_tfm_digest()
 crypto: mediatek - use crypto_shash_tfm_digest()
 crypto: n2 - use crypto_shash_tfm_digest()
 crypto: omap-sham - use crypto_shash_tfm_digest()
 crypto: s5p-sss - use crypto_shash_tfm_digest()
 nfc: s3fwrn5: use crypto_shash_tfm_digest()
 fscrypt: use crypto_shash_tfm_digest()
 ecryptfs: use crypto_shash_tfm_digest()
 nfsd: use crypto_shash_tfm_digest()
 ubifs: use crypto_shash_tfm_digest()
 Bluetooth: use crypto_shash_tfm_digest()
 sctp: use crypto_shash_tfm_digest()
 KEYS: encrypted: use crypto_shash_tfm_digest()
 ASoC: cros_ec_codec: use crypto_shash_tfm_digest()

arch/arm64/crypto/aes-glue.c               |  4 +--
crypto/essiv.c                             |  4 +--
crypto/shash.c                             | 16 +++++++++
drivers/crypto/axis/artpec6_crypto.c       | 10 ++----
drivers/crypto/ccp/ccp-crypto-sha.c        |  9 ++---
drivers/crypto/ccree/cc_cipher.c           |  9 ++---
drivers/crypto/hisilicon/sec2/sec_crypto.c |  5 ++-
drivers/crypto/mediatek/mtk-sha.c          |  7 ++--
drivers/crypto/n2_core.c                   |  7 ++--
drivers/crypto/omap-sham.c                 | 20 +++--------
drivers/crypto/s5p-sss.c                   | 39 ++++------------------
drivers/nfc/s3fwrn5/firmware.c             | 10 +-----
fs/crypto/fname.c                          |  7 +---
fs/crypto/hkdf.c                           |  6 +---
fs/ecryptfs/crypto.c                       | 17 +---------
fs/nfsd/nfs4recover.c                      | 26 ++++-----------
fs/ubifs/auth.c                            | 20 ++---------
fs/ubifs/master.c                          |  9 ++---
fs/ubifs/replay.c                          | 14 ++------
include/crypto/hash.h                      | 19 +++++++++++
net/bluetooth/smp.c                        |  6 +---
net/sctp/auth.c                            | 10 ++----
net/sctp/sm_make_chunk.c                   | 23 +++++--------
security/keys/encrypted-keys/encrypted.c   | 18 ++--------
sound/soc/codecs/cros_ec_codec.c           |  9 +----
25 files changed, 95 insertions(+), 229 deletions(-)
All applied.  Thanks.
-- 
Email: Herbert Xu [off-list ref]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Thread (6 messages) 6 messages, 4 authors, last reply 2020-05-08
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help