Re: [PATCH BlueZ] test: Enable test-mesh to send raw vendor commands

Hi Brian

On 22 Mar 2019, at 16.00, Gix, Brian [off-list ref] wrote:

quoted

quoted

On 22 Mar 2019, at 5.49, Inga Stotland [off-list ref] wrote:
+#       5 - on/off model client menu
+#       6 - send raw message
+#       7 - exit

Please don’t use numeric identifiers for commands in interactive tools. Use intuitive, human readable strings like we do in the other interactive tools in the tree. Numbers might be convenient for computers, but they’re not particularly human friendly :)

We do plan on making better tools, but this is mostly intended as a tester script to quickly allow us to test stuff, particularly the d-bus APIs, and demonstrate the way the methods are called from python.

Understood, however what I proposed

 - Doesn’t take really any extra effort
 - Is friendlier to the user
 - Is friendlier to the reader of the code (no need to do number lookups to understand the purpose of a branch)
 - Is consistent with the rest of the code base

… so I don’t understand why you wouldn’t want that, even if it’s a quick test tool :)

I suppose the long-term idea is to provide the same kind of interactive command-line interface as meshctl has provided for provisioner and configuration client role? In fact, would it make sense to keep using meshctl for that and hide the detail whether stuff is going via meshd or not?

Johan