Re: [v5 6/8] rsi: handle BT traffic in driver
From: Kalle Valo <hidden>
Date: 2018-02-01 07:10:31
Also in:
linux-wireless
Amitkumar Karwar [off-list ref] writes:
quoted hunk ↗ jump to hunk
From: Siva Rebbagondla <redacted> BT frames are passed through coex and hal modules to BUS. After firmware is loaded, based on the operating mode CARD READY frame comes for each protocol. When BT card ready is received, BT attach is called. Protocol operations are exchanged between the modules at initialization time. Signed-off-by: Siva Rebbagondla <redacted> Signed-off-by: Prameela Rani Garnepudi <redacted> Signed-off-by: Amitkumar Karwar <redacted> --- v5: Same as v3, v4 v3: bt_ops need not be present structure g_proto_ops. It is removed. v2: WLAN module depends on BT module. Updated in Kconfig --- drivers/net/wireless/rsi/Kconfig | 2 +- drivers/net/wireless/rsi/rsi_91x_coex.c | 4 ++- drivers/net/wireless/rsi/rsi_91x_core.c | 16 ++++++++---- drivers/net/wireless/rsi/rsi_91x_hal.c | 39 +++++++++++++++++++++++++++++ drivers/net/wireless/rsi/rsi_91x_main.c | 31 +++++++++++++++++++++++ drivers/net/wireless/rsi/rsi_91x_sdio_ops.c | 1 + drivers/net/wireless/rsi/rsi_common.h | 1 + drivers/net/wireless/rsi/rsi_hal.h | 10 ++++++++ drivers/net/wireless/rsi/rsi_main.h | 3 +++ 9 files changed, 100 insertions(+), 7 deletions(-)diff --git a/drivers/net/wireless/rsi/Kconfig b/drivers/net/wireless/rsi/Kconfig index 7c5e4ca..ad72c80 100644 --- a/drivers/net/wireless/rsi/Kconfig +++ b/drivers/net/wireless/rsi/Kconfig@@ -13,7 +13,7 @@ if WLAN_VENDOR_RSI config RSI_91X tristate "Redpine Signals Inc 91x WLAN driver support" - depends on MAC80211 + depends on MAC80211 && BT_RSI
I think this is evil, now the wlan driver cannot be enabled unless the bluetooth driver is enabled. And if I'm understanding correctly it won't even show up in the menuconfig. A much nicer approach would be that btcoex is just disabled in the wlan driver if BT_RSI is disabled. -- Kalle Valo