Thread (5 messages) 5 messages, 4 authors, 2018-01-23

Re: [PATCH v2] serdev: add method to set parity

From: Johan Hovold <johan@kernel.org>
Date: 2018-01-23 01:35:21
Also in: linux-renesas-soc, linux-serial

On Mon, Jan 22, 2018 at 06:56:32PM +0100, Ulrich Hecht wrote:
Adds serdev_device_set_parity() and an implementation for ttyport.
The interface uses an enum with the values SERIAL_PARITY_NONE,
SERIAL_PARITY_EVEN and SERIAL_PARITY_ODD.

Signed-off-by: Ulrich Hecht <redacted>
Reviewed-by: Sebastian Reichel <redacted>
---

Hi!

This revision addresses Johan's comments (see below for details) and adds
Sebastian's Reviewed-by tag. Thank you for your reviews!

CU
Uli


Changes since v1:
- added Reviewed-by tag
- expanded commit message
- shuffled stuff around to keep line-setting bits together
- clear CMSPAR
- (hopefully) detect errors correctly by checking tty->termios after call
  to tty_set_termios().
Thanks for the v2. Looks good to me now.

Reviewed-by: Johan Hovold <johan@kernel.org>

Johan
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help