Thread (20 messages) read the whole thread 20 messages, 2 authors, 2017-10-18

Re: [PATCH 3/9] sixaxis: Ask user whether cable configuration should be allowed

From: Bastien Nocera <hadess@hadess.net>
Date: 2017-10-18 01:51:17

On Wed, 2017-09-27 at 11:12 +0200, Szymon Janc wrote:
Hi Bastien,

On Monday, 4 September 2017 20:12:06 CEST Bastien Nocera wrote:
quoted
<snip>
+	char device_addr[18];
If this is needed only for debug then just convert address to string
in place 
where it is printed.
The string was in string format already when we get it from the device,
but I've switched that to pass around a bdaddr_t instead.
<snip>
quoted
+	closure = g_try_new0(struct authentication_closure, 1);
Just use new0() instead.
Fixed.

I've also added a btd_device_set_trusted() as well, which was bizarrely
missing from this patch. I guess it got lost when I started splitting
up the original patches.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help