Thread (7 messages) 7 messages, 3 authors, 2017-09-04

RE: [PATCH BlueZ 1/3] mesh: Fix for handling unprovisioned device

From: Gix, Brian <hidden>
Date: 2017-08-31 23:11:42

An unprovisioned device that does not advertise the ServiceData for an Unprovisioned Mesh Device does not comply with the specification.  The Service Data is the required method for an unprovisioned device to be recognized. 
quoted hunk ↗ jump to hunk
-----Original Message-----
From: linux-bluetooth-owner@vger.kernel.org [mailto:linux-bluetooth-
owner@vger.kernel.org] On Behalf Of Lukasz Rymanowski
Sent: Thursday, August 31, 2017 3:13 AM
To: linux-bluetooth@vger.kernel.org
Cc: Łukasz Rymanowski <redacted>
Subject: [PATCH BlueZ 1/3] mesh: Fix for handling unprovisioned device

If there is no ServiceData there is no valid provisioning data for PB-GATT
---
 mesh/main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mesh/main.c b/mesh/main.c
index b06f4352a..2289d7d10 100644
--- a/mesh/main.c
+++ b/mesh/main.c
@@ -503,7 +503,7 @@ static bool parse_service_data(GDBusProxy *proxy,
const char *target_uuid,
 	}

 	if (!g_dbus_proxy_get_property(proxy, "ServiceData", &iter))
-		return true;
+		return false;

 	if (dbus_message_iter_get_arg_type(&iter) != DBUS_TYPE_ARRAY)
 		return false;
--
2.11.0

--
To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
the body of a message to majordomo@vger.kernel.org More majordomo
info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help