Re: [PATCH v4 4/4] Bluetooth: hci_bcm: Add serdev support

Hi Marcel,


On 17/08/2017 21:48, Marcel Holtmann wrote:

Hi Loic,

quoted

Add basic support for Broadcom serial slave devices.
Probe the serial device, retrieve its maximum speed and
register a new hci uart device.

Tested/compatible with bcm43438 (RPi3).

Signed-off-by: Loic Poulain <redacted>
---
v2: dt-bindings as separate patch
     rebase on upcoming pi3 dts changes
v3: changes in bcm serdev drivers:
     name refactoring and additional comments
     Add generic host_set_baudrate method
     Use agnostic device_property_read
v4: changes in doc and dts:
     Add additional params to broadcom bt dt-bindings
     Set the max baudrate to 2000000 instead of 921600
     use chosen/stdout-path instead of console=
     remove useless earlyprintk
     same changes in bcm283x.dtsi

drivers/bluetooth/hci_bcm.c | 85 +++++++++++++++++++++++++++++++++++++++++++--
1 file changed, 83 insertions(+), 2 deletions(-)

I decided to amend your patch with the required Kconfig addition and then just applied 1/4 and 4/4 to bluetooth-next tree.

For 2/4 and 3/4, I think they should go through the DT tree since they depend on other changes. I can not apply since none of these changes are in any of my parent trees.

Thanks for the amend.

Indeed 2 and 3 depend on the following DT tree changes (Stefan):
[PATCH v2] ARM: dts: bcm283x: Move the BCM2837 DT contents from arm64 to 
arm.
[PATCH V2 0/3] ARM: bcm283x: Raspberry Pi Zero W support

Regards,
Loic