Re: [Unstrung-hackers] [RFC net-next] ipv6:ext_header: add function to handle RPL extension header option 0x63
From: Andreas Bardoutsos <hidden>
Date: 2017-05-05 07:55:54
Also in:
netdev
Yes I think we have faced the same problem,communication with RPL supporting devices was failing otherwise.Your patch is also more complete since it also implements #ifdef .About the comment,yes I have run checkpatch twice with no errors,but ok :) Στις 2017-05-05 08:59, JANARDHANACHARI KELLA έγραψε:
I was inserted this patch manually. It was working. on 4.9 kernel. check this bellow link for your ref. https://github.com/mwasilak/bluetooth-next/commit/f29c632ef6a6a1777815c97fd2f326faccc704f7 [2] On Thu, May 4, 2017 at 9:30 PM, Jiri Pirko [off-list ref] wrote:quoted
Thu, May 04, 2017 at 05:17:18PM CEST, bardoutsos@ceid.upatras.gr wrote:quoted
Signed-off-by: Andreas Bardoutsos <redacted> --- Hi all! I have added a dump function(always return true) to recognise RPLextensionquoted
header(RFC6553) Otherwise packet was dropped by kernel resulting in failingcommunication inquoted
RPL DAG's between linux running border routers and devices in the graph.For example communication with contiki OS running devices was previously impossible. include/uapi/linux/in6.h | 1 + net/ipv6/exthdrs.c | 13 +++++++++++++ 2 files changed, 14 insertions(+)diff --git a/include/uapi/linux/in6.h b/include/uapi/linux/in6.h index 46444f8fbee4..5cc12d309dfe 100644 --- a/include/uapi/linux/in6.h +++ b/include/uapi/linux/in6.h@@ -146,6 +146,7 @@ struct in6_flowlabel_req {#define IPV6_TLV_CALIPSO 7 /* RFC 5570 */ #define IPV6_TLV_JUMBO 194 #define IPV6_TLV_HAO 201 /* home address option */ +#define IPV6_TLV_RPL 99 /* RFC 6553 */ /* * IPV6 socket optionsdiff --git a/net/ipv6/exthdrs.c b/net/ipv6/exthdrs.c index b636f1da9aec..82ed60d3180e 100644 --- a/net/ipv6/exthdrs.c +++ b/net/ipv6/exthdrs.c@@ -785,6 +785,15 @@ static bool ipv6_hop_calipso(struct sk_buff*skb, intquoted
optoff) return false; } +/* RPL RFC 6553 */ + +static bool ipv6_hop_rpl(struct sk_buff *skb, int optoff) +{ + /*Dump function which always return true + *when rpl option is detected*/This is definitelly wrong formatting of comment. Did you run checkpatch?quoted
+ return true; +} + static const struct tlvtype_proc tlvprochopopt_lst[] = { { .type = IPV6_TLV_ROUTERALERT,@@ -798,6 +807,10 @@ static const struct tlvtype_proctlvprochopopt_lst[] = {quoted
.type = IPV6_TLV_CALIPSO, .func = ipv6_hop_calipso, }, + { + .type = IPV6_TLV_RPL, + .func = ipv6_hop_rpl, + }, { -1, } };-- To unsubscribe from this list: send the line "unsubscribe linux-wpan" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html [1]-- Sincerely Your's Janardhanachari Kella Contact:+91-9908469599 E-mail: eni.chari@gmail.com Links: ------ [1] http://vger.kernel.org/majordomo-info.html [2] https://github.com/mwasilak/bluetooth-next/commit/f29c632ef6a6a1777815c97fd2f326faccc704f7 _______________________________________________ Unstrung-hackers mailing list Unstrung-hackers@lists.sandelman.ca https://lists.sandelman.ca/mailman/listinfo/unstrung-hackers