[PATCH 3/4] Bluetooth: hci_ldisc: don't release resources in hci_uart_init_work()
flat view
STALE3692d
From: Boris Brezillon <hidden>
Date: 2016-08-19 07:38:55
Also in:
lkml
Subsystem:
bluetooth drivers, the rest · Maintainers:
Marcel Holtmann, Luiz Augusto von Dentz, Linus Torvalds
This is done in hci_uart_tty_close() and can lead to double cleanup if proto->close() is not tracking the closed/open state. Signed-off-by: Boris Brezillon <redacted> --- drivers/bluetooth/hci_ldisc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/bluetooth/hci_ldisc.c b/drivers/bluetooth/hci_ldisc.c
index de7f7f1f995c..27f73294edcb 100644
--- a/drivers/bluetooth/hci_ldisc.c
+++ b/drivers/bluetooth/hci_ldisc.c@@ -190,9 +190,7 @@ static void hci_uart_init_work(struct work_struct *work) err = hci_register_dev(hu->hdev); if (err < 0) { BT_ERR("Can't register HCI device"); - hci_free_dev(hu->hdev); - hu->hdev = NULL; - hu->proto->close(hu); + return; } set_bit(HCI_UART_REGISTERED, &hu->flags);
--
2.7.4