Thread (6 messages) 6 messages, 2 authors, 2016-07-27

Re: [PATCH BlueZ] test/example-gatt-server: Fix error on Property.GetAll

flat view

From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date: 2016-07-15 07:39:27

Hi,

On Thu, Jul 14, 2016 at 3:45 PM, Luiz Augusto von Dentz
[off-list ref] wrote:
quoted hunk ↗ jump to hunk
From: Luiz Augusto von Dentz <redacted>

get_properties is a method not a dictionary which cause the following
error:
  TypeError: 'method' object is not subscriptable
---
 test/example-gatt-server | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/test/example-gatt-server b/test/example-gatt-server
index 71aeb1b..84905f3 100755
--- a/test/example-gatt-server
+++ b/test/example-gatt-server
@@ -117,7 +117,7 @@ class Service(dbus.service.Object):
         if interface != GATT_SERVICE_IFACE:
             raise InvalidArgsException()

-        return self.get_properties[GATT_SERVICE_IFACE]
+        return self.get_properties()[GATT_SERVICE_IFACE]


 class Characteristic(dbus.service.Object):
@@ -164,7 +164,7 @@ class Characteristic(dbus.service.Object):
         if interface != GATT_CHRC_IFACE:
             raise InvalidArgsException()

-        return self.get_properties[GATT_CHRC_IFACE]
+        return self.get_properties()[GATT_CHRC_IFACE]

     @dbus.service.method(GATT_CHRC_IFACE,
                         in_signature='a{sv}',
@@ -222,7 +222,7 @@ class Descriptor(dbus.service.Object):
         if interface != GATT_DESC_IFACE:
             raise InvalidArgsException()

-        return self.get_properties[GATT_CHRC_IFACE]
+        return self.get_properties()[GATT_CHRC_IFACE]

     @dbus.service.method(GATT_DESC_IFACE,
                         in_signature='a{sv}',
--
2.7.4
Applied.


-- 
Luiz Augusto von Dentz
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help