Re: [PATCH] core/advertising: Fix byte order for MGMT_OP_ADD_ADVERTISING flags

From
Johan Hedberg <hidden>
Date
2016-03-17 08:02:01
Reply to
Andrejs Hanins, 2015-07-22
Hi,

On Wed, Jul 22, 2015, Andrejs Hanins wrote:
quoted hunk ↗ jump to hunk
Fix byte order for MGMT_OP_ADD_ADVERTISING flags
---
 src/advertising.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/advertising.c b/src/advertising.c
index d56b7a2..8c249d1 100644
--- a/src/advertising.c
+++ b/src/advertising.c
@@ -500,7 +500,7 @@ static DBusMessage *refresh_advertisement(struct advertisement *ad)
 		return btd_error_failed(ad->reg, "Failed");
 	}
 
-	cp->flags = flags;
+	cp->flags = htobl(flags);
 	cp->instance = ad->instance;
 	cp->adv_data_len = adv_data_len;
 	memcpy(cp->data, adv_data, adv_data_len);
I'm surprised you never pinged about this forgotten patch (which I
noticed now when cleaning up my linux-bluetooth folder). Anyway, the
patch has been applied. Thanks.

Johan
Thread (4 messages) 4 messages, 3 authors, last reply 2016-03-17
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help