Re: [PATCH] audio/a2dp - Fix unbalanced setup ref/unref
flat view
From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date: 2016-03-23 10:33:40
Hi Hsin-yu, On Wed, Mar 23, 2016 at 8:01 AM, Hsin-yu Chao [off-list ref] wrote:
Hi Luiz, We're now observing below crash pretty often on Chrome OS, and I still couldn't figure out the root cause. The only clue I got is that this crash happens after your commit 33b447d "audio: Fix possible crash when removing device". Thread 0 CRASHED [SIGABRT @ 0x00000000 ] MAGIC SIGNATURE THREAD 0x00007f6c4b0c7b82 (libc-2.19.so -raise.c:56 ) raise 0x00007f6c4b0c989f (libc-2.19.so -abort.c:89 ) abort 0x00007f6c4b10d527 (libc-2.19.so -libc_fatal.c:175 ) __libc_message 0x00007f6c4b113e08 (libc-2.19.so -malloc.c:4991 ) malloc_printerr 0x00007f6c4b11461a (libc-2.19.so -malloc.c:3837 ) _int_free 0x00007f6c4ba9d2d5 (bluetoothd -a2dp.c:2150 ) a2dp_cancel 0x00007f6c4baa68ab (bluetoothd -transport.c:231 ) media_owner_remove 0x00007f6c4baa6f64 (bluetoothd -transport.c:244 ) media_transport_remove_owner 0x00007f6c4baa73b0 (bluetoothd -transport.c:734 ) media_transport_free 0x00007f6c4bb0ddac (bluetoothd -object.c:658 ) remove_interface 0x00007f6c4bb0eb6c (bluetoothd -object.c:1382 ) g_dbus_unregister_interface 0x00007f6c4baa7620 (bluetoothd -transport.c:182 ) media_transport_destroy 0x00007f6c4baa436f (bluetoothd -media.c:246 ) clear_endpoint 0x00007f6c4baa46f1 (bluetoothd -media.c:468 ) release_endpoint 0x00007f6c4baa61ef (bluetoothd -media.c:1879 ) path_free 0x00007f6c4bb0ddac (bluetoothd -object.c:658 ) remove_interface 0x00007f6c4bb0eb6c (bluetoothd -object.c:1382 ) g_dbus_unregister_interface 0x00007f6c4b9b1ad4 (libglib-2.0.so.0.3400.3 -gslist.c:894 ) g_slist_foreach 0x00007f6c4bada802 (bluetoothd -adapter.c:4171 ) adapter_remove 0x00007f6c4bae88a3 (bluetoothd -adapter.c:7453 ) index_removed 0x00007f6c4bb12c6f (bluetoothd -queue.c:251 ) queue_foreach 0x00007f6c4bb14386 (bluetoothd -mgmt.c:280 ) can_read_data 0x00007f6c4bb20ff5 (bluetoothd -io-glib.c:170 ) watch_callback 0x00007f6c4b991c7e (libglib-2.0.so.0.3400.3 -gmain.c:2715 ) g_main_context_dispatch 0x00007f6c4b992087 (libglib-2.0.so.0.3400.3 -gmain.c:3290 ) g_main_context_iterate 0x00007f6c4b9924f9 (libglib-2.0.so.0.3400.3 -gmain.c:3484 ) g_main_loop_run 0x00007f6c4ba94f90 (bluetoothd -main.c:661 ) main 0x00007f6c4b0b2fb5 (libc-2.19.so -libc-start.c:292 ) __libc_start_main 0x00007f6c4ba95770 (bluetoothd + 0x00019770 ) 0x00007ffdd7f667b7 Could you share any idea or hint on this crash?
Try with valgrind it usually give a much better picture what is going on. If the patch you mention is related to the problem then you would see: bluetoothd[31136]: profiles/audio/a2dp.c:a2dp_cancel() aborting setup 0x8856b10 bluetoothd[31136]: profiles/audio/a2dp.c:setup_unref() 0x8856b10: ref=0 bluetoothd[31136]: profiles/audio/a2dp.c:setup_free() 0x8856b10 bluetoothd[31136]: profiles/audio/avdtp.c:avdtp_unref() 0x884f9d0: ref=1 bluetoothd[31136]: src/service.c:change_state() 0x870fa80: device 94:20:53:2E:08:CE profile a2dp-sink state changed: disconnecting -> disconnected (0) bluetoothd[31136]: profiles/audio/avdtp.c:avdtp_unref() 0x884f9d0: ref=0 bluetoothd[31136]: src/service.c:change_state() 0x8a4b3b0: device 94:20:53:2E:08:CE profile Headset Voice gateway state changed: connected -> disconnecting (0) bluetoothd[31136]: src/service.c:change_state() 0x8a4b3b0: device 94:20:53:2E:08:CE profile Headset Voice gateway state changed: disconnecting -> disconnected (0) bluetoothd[31136]: src/service.c:btd_service_unref() 0x8a4b3b0: ref=2 bluetoothd[31136]: profiles/audio/avdtp.c:avdtp_connect_cb() AVDTP: connected signaling channel to 94:20:53:2E:08:CE bluetoothd[31136]: profiles/audio/avdtp.c:avdtp_connect_cb() AVDTP imtu=672, omtu=895 bluetoothd[31136]: profiles/audio/avdtp.c:session_cb() bluetoothd[31136]: profiles/audio/avdtp.c:avdtp_parse_resp() DISCOVER request succeeded bluetoothd[31136]: profiles/audio/avdtp.c:avdtp_discover_resp() seid 5 type 1 media 0 in use 0 bluetoothd[31136]: profiles/audio/avdtp.c:avdtp_discover_resp() seid 3 type 1 media 0 in use 0 bluetoothd[31136]: profiles/audio/avdtp.c:avdtp_discover_resp() seid 2 type 1 media 0 in use 0 bluetoothd[31136]: profiles/audio/avdtp.c:avdtp_discover_resp() seid 1 type 1 media 0 in use 0 bluetoothd[31136]: profiles/audio/avdtp.c:session_cb() bluetoothd[31136]: profiles/audio/avdtp.c:avdtp_parse_resp() GET_CAPABILITIES request succeeded bluetoothd[31136]: profiles/audio/avdtp.c:avdtp_get_capabilities_resp() seid 5 type 1 media 0 bluetoothd[31136]: profiles/audio/avdtp.c:session_cb() bluetoothd[31136]: profiles/audio/avdtp.c:avdtp_parse_resp() GET_CAPABILITIES request succeeded bluetoothd[31136]: profiles/audio/avdtp.c:avdtp_get_capabilities_resp() seid 3 type 1 media 0 bluetoothd[31136]: profiles/audio/avdtp.c:session_cb() bluetoothd[31136]: profiles/audio/avdtp.c:avdtp_parse_resp() GET_CAPABILITIES request succeeded bluetoothd[31136]: profiles/audio/avdtp.c:avdtp_get_capabilities_resp() seid 2 type 1 media 0 bluetoothd[31136]: profiles/audio/avdtp.c:session_cb() bluetoothd[31136]: profiles/audio/avdtp.c:avdtp_parse_resp() GET_CAPABILITIES request succeeded bluetoothd[31136]: profiles/audio/avdtp.c:avdtp_get_capabilities_resp() seid 1 type 1 media 0 bluetoothd[31136]: profiles/audio/avdtp.c:connection_lost() Disconnected from 94:20:53:2E:08:CE It is not completely correct because it seems we are not able to cancel the connection request itself, but it doesn't crash for me.