RE: [PATCH v4] Bluetooth: hci_uart: Support firmware download for Marvell

Hi Marcel,

Do you have any comments for this patch?
Please let us know if you have any more suggestions for the improvements.

From: Amitkumar Karwar [mailto:akarwar@marvell.com]
Sent: Thursday, March 03, 2016 5:27 PM
To: linux-bluetooth@vger.kernel.org
Cc: Cathy Luo; linux-kernel@vger.kernel.org; Nishant Sarmukadam;
Ganapathi Bhat; Amitkumar Karwar
Subject: [PATCH v4] Bluetooth: hci_uart: Support firmware download for
Marvell

From: Ganapathi Bhat <redacted>

This patch implement firmware download feature for Marvell Bluetooth
devices. If firmware is already downloaded, it will skip downloading.

Signed-off-by: Ganapathi Bhat <redacted>
Signed-off-by: Amitkumar Karwar <redacted>
---
v2: Fixed compilation warning reported by kbuild test robot
v3: Addressed review comments from Marcel Holtmann
    a) Removed vendor specific code from hci_ldisc.c
    b) Get rid of static forward declaration
    c) Removed unnecessary heavy nesting
    d) Git rid of module parameter and global variables
    e) Add logic to pick right firmware image
v4: Addresses review comments from Alan
    a) Use existing kernel helper APIs instead of writing own.
    b) Replace mdelay() with msleep()
---

Regards,
Amitkumar