Thread (3 messages) 3 messages, 3 authors, 2016-01-21

Re: [PATCH] Bluetooth: add hdev check to avoid passing null pointer

flat view

From: Johan Hedberg <hidden>
Date: 2016-01-21 08:43:10

Hi Fuang,

On Thu, Jan 21, 2016, Fugang Duan wrote:
quoted hunk ↗ jump to hunk
Function hci_mgmt_cmd() may pass hdev with null pointer to hci_mgmt_handler->func()
like below code:
	err = handler->func(sk, hdev, cp, len);

Add hdev check to avoid passing null pointer.

Signed-off-by: Fugang Duan <redacted>
---
 net/bluetooth/hci_sock.c | 2 ++
 1 file changed, 2 insertions(+)
diff --git a/net/bluetooth/hci_sock.c b/net/bluetooth/hci_sock.c
index 1298d72..7fdfc80 100644
--- a/net/bluetooth/hci_sock.c
+++ b/net/bluetooth/hci_sock.c
@@ -1186,6 +1186,8 @@ static int hci_mgmt_cmd(struct hci_mgmt_chan *chan, struct sock *sk,
 
 	if (hdev && chan->hdev_init)
 		chan->hdev_init(sk, hdev);
+	else if (!hdev)
+		goto done;
Why are you resending this? Did you see my response to your earlier
submission?

Johan
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help