Re: [PATCH v2 0/4] Bluetooth: hci_bcm: Add ACPI and PM support

Hello Marcel,

On 07/08/2015 18:45, Marcel Holtmann wrote:

Hi Fred,

quoted

These patches move PM support from rfkill-gpio to hci_uart module.
On, off, suspend and resume functions are supported.
They also parse the ACPI entry to find initial UART baud rate.

v1->v2:
- Add BCM2E67 device in acpi_device_id table
- Add suspend/resume functions

looks pretty good. My only concern is the race between bcm_data and bcm_device. Is that a valid concern from my side or can that never happen? Meaning do we need to protect against removal / unbinding of the platform device while the line discipline is active.

I do not found a way to protect against device unbinding, so I will 
check if bcm_device is still in bsm_device_list before using it.

Regards

Fred