Thread (13 messages) 13 messages, 3 authors, 2015-06-17

Re: [PATCH] BlueZ line discipline baud rate setting update

From: Marcel Holtmann <marcel@holtmann.org>
Date: 2015-06-15 17:35:42

Hi Ilya,
quoted hunk ↗ jump to hunk
Bring the tty into a known 8 bits, 1 start bit, 1 stop bit,
hardware flow control state with a given baud rate.

Signed-off-by: Ilya Faenson <redacted>
---
drivers/bluetooth/hci_ldisc.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/bluetooth/hci_ldisc.c b/drivers/bluetooth/hci_ldisc.c
index ac87346..606cc5a 100644
--- a/drivers/bluetooth/hci_ldisc.c
+++ b/drivers/bluetooth/hci_ldisc.c
@@ -271,9 +271,16 @@ void hci_uart_set_baudrate(struct hci_uart *hu, unsigned int speed)
	struct tty_struct *tty = hu->tty;
	struct ktermios ktermios;

+	/* Bring the UART into a known state with a given baud rate */
	ktermios = tty->termios;
	ktermios.c_cflag &= ~CBAUD;
-	ktermios.c_cflag |= BOTHER;
+	ktermios.c_iflag &= ~(IGNBRK | BRKINT | PARMRK | ISTRIP | INLCR |
+			    IGNCR | ICRNL | IXON);
I think this one needs to align like this:

			&= ~(IGNBRK | .. |
			     IGNCR | ..);

However I can fix that one easily inline. So no worries.

Fred, can you test this patch so I can add a Tested-by line.

Regards

Marcel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help