Thread (13 messages) 13 messages, 4 authors, 2015-06-30

Re: [4.1.0-07254-gc13c810] Regression: Bluetooth not working.

From: Marcel Holtmann <marcel@holtmann.org>
Date: 2015-06-26 09:37:49
Also in: lkml
Subsystem: bluetooth subsystem, the rest · Maintainers: Marcel Holtmann, Luiz Augusto von Dentz, Linus Torvalds

Hi Joerg,
Bluetooth is inoperable in current Linus tree and the
first bad commit is:

835a6a2f8603237a3e6cded5a6765090ecb06ea5 is the first bad commit
commit 835a6a2f8603237a3e6cded5a6765090ecb06ea5
Author: Alexey Dobriyan [off-list ref]
Date:   Wed Jun 10 20:28:33 2015 +0300

   Bluetooth: Stop sabotaging list poisoning

   list_del() poisons pointers with special values, no need to overwrite them.

   Signed-off-by: Alexey Dobriyan [off-list ref]
   Signed-off-by: Marcel Holtmann [off-list ref]

My BT adapter is an intel 8087:07da
I reverted that commit and this fixed the problem for me.
today we had a patch from Tedd fixing the list initialization in the HIDP code.
diff --git a/net/bluetooth/hidp/core.c b/net/bluetooth/hidp/core.c
index 9070dfd6b4ad..f1a117f8cad2 100644
--- a/net/bluetooth/hidp/core.c
+++ b/net/bluetooth/hidp/core.c
@@ -915,6 +915,7 @@ static int hidp_session_new(struct hidp_session **out, const bdaddr_t *bdaddr,
        session->conn = l2cap_conn_get(conn);
        session->user.probe = hidp_session_probe;
        session->user.remove = hidp_session_remove;
+       INIT_LIST_HEAD(&session->user.list);
        session->ctrl_sock = ctrl_sock;
        session->intr_sock = intr_sock;
        skb_queue_head_init(&session->ctrl_transmit);
Could this be fixing it for you as well?

Regards

Marcel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help