Thread (2 messages) flat view 2 messages, 1 author, 2014-07-31
STALE4390d

[PATCH BlueZ] shared/queue: Fix not allowing to remove NULL entries

From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date: 2014-07-29 14:29:29
Subsystem: the rest · Maintainer: Linus Torvalds

From: Luiz Augusto von Dentz <redacted>

queue_remove should not check the data pointer since both queue_push_head
and queue_push_tail don't check it is possible to have NULL pointers in
the queue therefore queue_remove shall be able to remove them.
---
 src/shared/queue.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/shared/queue.c b/src/shared/queue.c
index 3bdc1ec..3ca3ca6 100644
--- a/src/shared/queue.c
+++ b/src/shared/queue.c
@@ -238,7 +238,7 @@ bool queue_remove(struct queue *queue, void *data)
 {
 	struct queue_entry *entry, *prev;
 
-	if (!queue || !data)
+	if (!queue)
 		return false;
 
 	for (entry = queue->head, prev = NULL; entry;
-- 
1.9.3
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help