Thread (1 message) 1 message, 1 author, 2014-06-05

Re: [PATCH] android/hal-audio: Fix memory leak

From: Andrzej Kaczmarek <hidden>
Date: 2014-06-05 15:18:27

Hi Andrei,

On 5 June 2014 16:51, Andrei Emeltchenko
[off-list ref] wrote:
quoted hunk
From: Andrei Emeltchenko <redacted>

Fixes clang warning:
...
android/hal-audio.c:484:3: warning: Potential leak of memory pointed to
by 'preset'
...
---
 android/hal-audio.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/android/hal-audio.c b/android/hal-audio.c
index 439b583..4d3cdb1 100644
--- a/android/hal-audio.c
+++ b/android/hal-audio.c
@@ -482,6 +482,7 @@ static bool open_endpoint(struct audio_endpoint **epp,

        if (!ep) {
                error("Cound not find opened endpoint");
+               free(preset);
                return false;
        }
I'd rather do 'goto failed' here so we also close fd.

BR,
Andrzej
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help