Thread (6 messages) 6 messages, 2 authors, 2014-02-02

Re: [PATCH 1/4] android/hal-audio: Check calloc return value

flat view

From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date: 2014-02-02 15:46:41

Hi Andrei,

On Fri, Jan 31, 2014 at 6:18 AM, Andrei Emeltchenko
[off-list ref] wrote:
quoted hunk ↗ jump to hunk
From: Andrei Emeltchenko <redacted>

calloc() might return NULL and is usually checked for NULL in BlueZ.
---
 android/hal-audio.c | 2 ++
 1 file changed, 2 insertions(+)
diff --git a/android/hal-audio.c b/android/hal-audio.c
index b1323b0..35bafe7 100644
--- a/android/hal-audio.c
+++ b/android/hal-audio.c
@@ -313,6 +313,8 @@ static int sbc_codec_init(struct audio_preset *preset, uint16_t mtu,
        }

        sbc_data = calloc(sizeof(struct sbc_data), 1);
+       if (!sbc_data)
+               return AUDIO_STATUS_FAILED;

        memcpy(&sbc_data->sbc, preset->data, preset->len);

--
1.8.3.2
Pushed, thanks.


-- 
Luiz Augusto von Dentz
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help