Re: [PATCH] android/tester: Fix slang "never used" warning
From: Szymon Janc <hidden>
Date: 2014-02-21 16:00:26
Hi Andrei, On Friday 21 of February 2014 17:46:47 Andrei Emeltchenko wrote:
quoted hunk ↗ jump to hunk
From: Andrei Emeltchenko <redacted> The patch fixes following warning: ... android/android-tester.c:2185:2: warning: Value stored to 'adapter_status' is never read adapter_status = data->if_bluetooth->set_adapter_property(prop); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ... --- android/android-tester.c | 4 ++++ 1 file changed, 4 insertions(+)diff --git a/android/android-tester.c b/android/android-tester.c index 84c6ca9..47f918c 100644 --- a/android/android-tester.c +++ b/android/android-tester.c@@ -2190,6 +2190,10 @@ static void test_getprop_bdname_success(const void *test_data) init_test_conditions(data); adapter_status = data->if_bluetooth->set_adapter_property(prop); + if (adapter_status != BT_STATUS_SUCCESS) { + tester_setup_failed();
This should be tester_test_failed().
+ return; + } adapter_status = data->if_bluetooth->get_adapter_property((*prop).type); check_expected_status(adapter_status);
-- Best regards, Szymon Janc