Thread (11 messages) flat view 11 messages, 2 authors, 2014-02-28

Re: [PATCHv2 1/9] unit/avrcp: Add /TP/PAS/BV-06-C test

From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date: 2014-02-28 14:28:18

Hi Andrei,

On Fri, Feb 28, 2014 at 3:18 PM, Andrei Emeltchenko
[off-list ref] wrote:
quoted hunk ↗ jump to hunk
From: Andrei Emeltchenko <redacted>

Test verifies that the list player application setting values response
issued from the Target.
---
 unit/test-avrcp.c | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)
diff --git a/unit/test-avrcp.c b/unit/test-avrcp.c
index db9cb92..51fe064 100644
--- a/unit/test-avrcp.c
+++ b/unit/test-avrcp.c
@@ -355,6 +355,26 @@ static uint8_t avrcp_handle_get_player_attr_text(struct avrcp *session,
        return AVC_CTYPE_STABLE;
 }

+static uint8_t avrcp_handle_list_player_values(struct avrcp *session,
+                               uint8_t transaction, uint16_t *params_len,
+                               uint8_t *params, void *user_data)
+{
+       DBG("params[0] %d params_len %d", params[0], *params_len);
+
+       if (*params_len != 1)
+               goto fail;
+
+       *params_len = 1;
+       params[0] = 0;
+       return AVC_CTYPE_STABLE;
+
+fail:
+       *params_len = 1;
+       params[0] = AVRCP_STATUS_INVALID_PARAM;
+
+       return AVC_CTYPE_REJECTED;
+}
+
 static const struct avrcp_control_handler control_handlers[] = {
                { AVRCP_GET_CAPABILITIES, AVC_CTYPE_STATUS,
                                        avrcp_handle_get_capabilities },
@@ -362,6 +382,8 @@ static const struct avrcp_control_handler control_handlers[] = {
                                        avrcp_handle_list_attributes },
                { AVRCP_GET_PLAYER_ATTRIBUTE_TEXT, AVC_CTYPE_STATUS,
                                        avrcp_handle_get_player_attr_text },
+               { AVRCP_LIST_PLAYER_VALUES, AVC_CTYPE_STATUS,
+                                       avrcp_handle_list_player_values },
                { },
 };
@@ -518,5 +540,15 @@ int main(int argc, char *argv[])
                                AVRCP_GET_PLAYER_ATTRIBUTE_TEXT,
                                0x00, 0x00, 0x01, 0x00));

+       define_test("/TP/PAS/BV-06-C", test_server,
+                       raw_pdu(0x00, 0x11, 0x0e, 0x01, 0x48, 0x00,
+                               0x00, 0x19, 0x58,
+                               AVRCP_LIST_PLAYER_VALUES,
+                               0x00, 0x00, 0x01, 0x00),
+                       raw_pdu(0x02, 0x11, 0x0e, 0x0c, 0x48, 0x00,
+                               0x00, 0x19, 0x58,
+                               AVRCP_LIST_PLAYER_VALUES,
+                               0x00, 0x00, 0x01, 0x00));
+
        return g_test_run();
 }
--
1.8.3.2
Hold on with the unit tests, we need to add the asynchronous response
support otherwise it wont work with Android.


-- 
Luiz Augusto von Dentz
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help