Thread (11 messages) 11 messages, 3 authors, 2014-01-30

Re: [PATCH v3 0/4] Regression fixes for rfcomm/tty.c

flat view

From: Marcel Holtmann <marcel@holtmann.org>
Date: 2014-01-28 12:08:58

Hi Gianluca,
quoted
quoted
quoted
all 4 patches have been applied to bluetooth-next tree.
Maybe a bit late, but I've just seen they miss a Cc: stable@vger.kernel.org to automatically end up in 3.12 and 3.13 too.
we can always promote them to stable. On Purpose I wanted them to cycle through bluetooth-next for a while to make sure they do not cause any other regressions.
Unfortunately it seems I overlooked the fact that rfcomm_dev_activate() is
called with the port->mutex held. So patches 2/3/4 cause a regression I missed
because I didn't turn on the appropriate debug options (circular locking
dependency, a bug report already appeared on this list).

I'm afraid this all stems from my partial knowledge of the tty_port code and
unfortunately I don't know how to solve the problem right now.

I think it's better to revert those patches for the moment.
can we get this fixed instead. If I revert them, I have a different issue. So I am trading one bug for another one.

Regards

Marcel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help