Thread (18 messages) 18 messages, 3 authors, 2013-10-01

Re: [PATCH v5 1/2] Bluetooth: btmrvl: add setup handler

From: Marcel Holtmann <marcel@holtmann.org>
Date: 2013-09-24 04:23:49
Also in: linux-wireless

Hi Bing,
quoted
quoted
-	btmrvl_send_module_cfg_cmd(priv, MODULE_BRINGUP_REQ);
+	hdev->setup = btmrvl_setup;
just to make sure you guys understand how ->setup() works. It is only called once. Bringing the
adapter down and up again does not call ->setup() a second time. So do you guys need this setup_done
variable and if so, then you need to be a bit more verbose and help me understand why.
It's observed that sometimes the setup handler is called twice when Bluetooth daemon is running in background. We will rebase to latest commit on bluetooth-next tree and test again. If the issue is gone with the latest code in -next tree we will remove the setup_done flag.
that is a bug. It should only be ever called once. Could this be due to RFKILL issue we had? Please re-test with Johan's patches applied and check if it makes a difference. Otherwise please send some logs since we want to get this fixed.

Regards

Marcel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help