Re: [PATCH v8 7/8] Bluetooth: SCO connection fallback

Hi Fred,

quoted

before we do the fallback handling, lets get the basic CVSD vs transparent work done properly. The one thing that I am missing is the handling of SCO/eSCO setup error handling. Like say when using connect() and we try to establish transparent link where not available. Or accept() with defer setup and the transparent link does not work out.

The fallback handling can be a separate patch once the others are all in a mergable state.

AFAIR if Accept Synchronous Connection does not specify a compatible
voice setting, Synchronous Connection Complete will return error
2.13 INVALID HCI COMMAND PARAMETERS (0x12).
Setup Synchronous Connection also returns error in Synchronous Connection Complete.

This is the reason why it is negociated before in profile.

I am not sure I like that. What we want is to return proper error codes when a connect() or accept() + read() fails due to an invalid combination.

Regards

Marcel