Thread (8 messages) read the whole thread 8 messages, 2 authors, 2013-06-24

Re: [PATCH BlueZ v0 0/6] Exploit btd_service's userdata pointer

From: Johan Hedberg <hidden>
Date: 2013-06-24 08:19:05

Hi Mikel,

On Mon, May 27, 2013, Mikel Astiz wrote:
With the adoption of btd_service, profile implementations can benefit
from the provided userdata pointer which can replace the previously
necessary lists to associate services with custom private types.

The proposed change not only removes boilerplate code but also data
redundancy, presumably making the codebase more robust.

This patchset addresses the first examples which looked like more
obvious to refactor. Note that some of the profiles were not tested
due to lack of hardware.

Patch 2/6 fixes an issue that I came across during this work.

Mikel Astiz (6):
  network: Remove duplicated search
  network: Fix missing NULL check for given UUID
  network: Remove find_connection()
  deviceinfo: Use btd_service userdata pointer
  scanparam: Use btd_service userdata pointer
  input: Use btd_service userdata pointer

 profiles/deviceinfo/deviceinfo.c | 46 ++++++----------------------------------
 profiles/input/device.c          | 37 +++++++++-----------------------
 profiles/network/connection.c    | 38 ++++++++++++---------------------
 profiles/scanparam/scan.c        | 36 ++++++-------------------------
 4 files changed, 35 insertions(+), 122 deletions(-)
Sorry for the delay in processing this set. It looks fine to me and all
patches in it have now been pushed upstream.

Johan
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help