Re: [PATCH 07/12 v3] Bluetooth: Fix mgmt powered indication by using a HCI transaction

From: Johan Hedberg <redacted>

The response to mgmt_set_powered should be returned only when all
related HCI commands have completed. To properly do this make use of a
HCI transaction with a callback to indicate its completion.

Signed-off-by: Johan Hedberg <redacted>
---
 net/bluetooth/mgmt.c |   43 ++++++++++++++++++++++++++++++++++---------
 1 file changed, 34 insertions(+), 9 deletions(-)

diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c
index 39395c7..042a6c7 100644
--- a/net/bluetooth/mgmt.c
+++ b/net/bluetooth/mgmt.c

@@ -3058,19 +3058,33 @@ static int set_bredr_scan(struct hci_dev *hdev)
        return hci_send_cmd(hdev, HCI_OP_WRITE_SCAN_ENABLE, 1, &scan);
 }

+static void powered_complete(struct hci_dev *hdev, u16 opcode, int status)
+{
+       struct cmd_lookup match = { NULL, hdev };
+
+       mgmt_pending_foreach(MGMT_OP_SET_POWERED, hdev, settings_rsp, &match);
+
+       new_settings(hdev, match.sk);
+
+       if (match.sk)
+               sock_put(match.sk);
+}
+
 int mgmt_powered(struct hci_dev *hdev, u8 powered)
 {
        struct cmd_lookup match = { NULL, hdev };
+       u8 status = MGMT_STATUS_NOT_POWERED;
+       u8 zero_cod[] = { 0, 0, 0 };
        int err;

        if (!test_bit(HCI_MGMT, &hdev->dev_flags))
                return 0;

-       mgmt_pending_foreach(MGMT_OP_SET_POWERED, hdev, settings_rsp, &match);
-
        if (powered) {
                u8 link_sec;

+               hci_start_transaction(hdev);
+