Thread (25 messages) read the whole thread 25 messages, 3 authors, 2013-03-16

Re: [PATCH 02/16] Bluetooth: change bt_sock_unregister() to return void

From: Gustavo Padovan <hidden>
Date: 2013-02-26 19:52:51

Hi David,

* David Herrmann [off-list ref] [2013-02-24 19:36:52 +0100]:
There is no reason a caller ever wants to check the return type of this
call. _Iff_ a user successfully called bt_sock_register(), they're allowed
to call bt_sock_unregister().
All other calls in the kernel (device_del, device_unregister, kfree(), ..)
that are logically equivalent return void. Lets not make callers think
they have to check the return type of this call and instead simply return
void.

We guarantee that after bt_sock_unregister() is called, the socket type
_is_ unregistered. If that is not what the caller wants, they're using the
wrong function, anyway.

Signed-off-by: David Herrmann <redacted>
---
 include/net/bluetooth/bluetooth.h |  2 +-
 net/bluetooth/af_bluetooth.c      | 15 +++------------
 2 files changed, 4 insertions(+), 13 deletions(-)
Patch has been applied to bluetooth-next. Thanks.

	Gustavo
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help