Thread (13 messages) flat view 13 messages, 2 authors, 2013-03-01
STALE4903d

[PATCH BlueZ 01/10 v3] player: Fix property Device type

From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Date: 2013-02-28 14:47:02
Subsystem: the rest · Maintainer: Linus Torvalds

From: Luiz Augusto von Dentz <redacted>

Device property should be an objecy path not a string.
---
 profiles/audio/player.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/profiles/audio/player.c b/profiles/audio/player.c
index 466b44a..b222643 100644
--- a/profiles/audio/player.c
+++ b/profiles/audio/player.c
@@ -290,7 +290,8 @@ static gboolean get_device(const GDBusPropertyTable *property,
 {
 	struct media_player *mp = data;
 
-	dbus_message_iter_append_basic(iter, DBUS_TYPE_STRING, &mp->device);
+	dbus_message_iter_append_basic(iter, DBUS_TYPE_OBJECT_PATH,
+								&mp->device);
 
 	return TRUE;
 }
@@ -570,7 +571,7 @@ static const GDBusPropertyTable media_player_properties[] = {
 					G_DBUS_PROPERTY_FLAG_EXPERIMENTAL },
 	{ "Track", "a{sv}", get_track, NULL, NULL,
 					G_DBUS_PROPERTY_FLAG_EXPERIMENTAL },
-	{ "Device", "s", get_device, NULL, NULL,
+	{ "Device", "o", get_device, NULL, NULL,
 					G_DBUS_PROPERTY_FLAG_EXPERIMENTAL },
 	{ "Browsable", "b", get_browsable, NULL, browsable_exists,
 					G_DBUS_PROPERTY_FLAG_EXPERIMENTAL },
-- 
1.8.1.2
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help