Thread (3 messages) read the whole thread 3 messages, 2 authors, 2013-01-29

Re: [PATCH] Bluetooth: Fix handling of unexpected SMP PDUs

From: Marcel Holtmann <marcel@holtmann.org>
Date: 2013-01-29 06:50:48

Hi Johan,
The hdev->smp_chan pointer can be NULL if SMP PDUs arrive at unexpected
moments. To avoid NULL pointer dereferences the code should be checking
for this and simply ignore such PDUs. This patch fixes the issue by
adding the checks into each individual PDU handler. It's done there
instead of a global place since for some PDUs it *is* ok for smp_chan to
be NULL (e.g. pairing request and security request).
I am not sure we want to ignore such PDUs. Don't we have to respond with
an error and actually disconnect at this point. Otherwise this might
open up a denial of service attack.

Regards

Marcel

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help