Thread (8 messages) flat view 8 messages, 4 authors, 2012-12-20

Re: [PATCH] gdbus: Fix double free when calling g_dbus_remove_all_watches

From: Tomasz Bursztyka <hidden>
Date: 2012-12-20 07:46:32

Hi Lucas,
quoted hunk ↗ jump to hunk
@@ -309,6 +309,9 @@ static void filter_data_call_and_free(struct filter_data *data)
                 g_free(cb);
         }

+       g_slist_free(data->callbacks);
+       data->callbacks = NULL;
+
why not just removing the g_free(cb)  above?
I did so to avoid filter_data_free() to go through the list once again,
but indeed if the list is not going to be big, it's superfluous then.

Tomasz
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help